#101 Union contributor is generate fromJson as method and not factory #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spideythewebhead
force-pushed
the
101-union-contributor-is-generating-wrong-fromjson
branch
2 times, most recently
from
9c6ac6a
to
8e38fea
Compare
nikosportolos
approved these changes
Nov 20, 2022
- Also swapped "expected" and "actual" values in tests
spideythewebhead
force-pushed
the
101-union-contributor-is-generating-wrong-fromjson
branch
from
8e38fea
to
fa21976
Compare
spideythewebhead
deleted the
101-union-contributor-is-generating-wrong-fromjson
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.