-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when zooming in, there should be no need to mark all nodes as hidden #117
Comments
Possibly, feel free to submit a PR. :) |
Btw, what are the benefits of using d3? I though the idea is to handle large data sets with ease, but all d3 examples I'm looking at are super slow even on small data sets. E.g. if I just create |
Bit more complicated than that I believe, but sure, there are other options that might perform better in certain cases, just a lot more heavy lifting to be done. |
That's exactly what I'm curious about. What this heavy lifting is and how heavy is it. I know that from outside every project/code looks trivial and simple, so I'm trying to understand what I'm missing. |
Is there particular reason why |
No particular reason. |
I noticed that d3-flame-graph casually traverses the entire data structure for different reasons. This makes many operations slower than it would be desired.
Specifically, when zooming in, it should be enough to mark nodes on the same level as zoomed node as hidden and when such flag is set, return null from getChildren().
The text was updated successfully, but these errors were encountered: