Allow passing comparators to flamegraph.sort #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has always been possible-- and has examples in documentation however they typescript definitions did not include this until now
|
Thank you @nickgirardo! Good catch! A generic variable would be preferable here I believe. I have a few cases where a modified string is passed. |
spiermar
requested changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a third overload for
sortto the type definitions. This definition allows passing in a comparator function.You can see an example of this in the existing examples. While this works fine, the TypeScript definitions only allowed for passing no args or a boolean in.
You will notice this is a simple comparator function, similar to those used by d3 array in its type definitions. Notice that I've bound the generic variable
There toStackFrame. I'm not 100% sure that's correct. If other things besidesStackFrames could be passed as arguments tosort, we can modify it or keep it generic.