Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

dataStorage vs persistence value #171

Closed
kfox1111 opened this issue Mar 27, 2023 · 3 comments
Closed

dataStorage vs persistence value #171

kfox1111 opened this issue Mar 27, 2023 · 3 comments

Comments

@kfox1111
Copy link
Contributor

The very common convention is to have a persistence flag for dealing with volumes. This chart is using dataStorage instead. We should probably consider changing this flag before 1.0.

@marcofranssen
Copy link
Contributor

We are naming the things as they are named on the Spire side. So dataStorage is named because of the dataStorage config option in the spire config.

@kfox1111
Copy link
Contributor Author

Its a helm chart though and the convention that most helm users expect is persistence rather then dataStore. Which way will be less confusing to users?

@kfox1111
Copy link
Contributor Author

kfox1111 commented Apr 7, 2023

We talked it over during the last meeting and decided to go with persistence.

@kfox1111 kfox1111 closed this as completed Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants