This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Add experimental flag for nested configuration #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a non working flag for specifying a mode of nested spire along with some unit tests to ensure output. Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
requested review from
marcofranssen,
developer-guy,
dfeldman,
faisal-memon and
mrsabath
as code owners
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
This was referenced May 18, 2023
Merged
|
@edwbuck Please review with priority Let's get this one some movement. |
|
From commentary in meetings and other places, it seems the main complaint (relayed to me by Kevin, originating from Marco) is this "adds too much testing". @kfox1111 Would you please remove the testing code, so we can split the testing from the flag and put the testing in a different PR? Maybe we can get the flag accepted without the tests. |
edwbuck
approved these changes
Jun 28, 2023
|
No longer needed. Overcome by events. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a non working flag for specifying a mode of nested spire along with some unit tests to ensure output.