Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Add edited to helm-chart-ci-ignore.yaml #289

Closed
wants to merge 1 commit into from

Conversation

faisal-memon
Copy link
Contributor

Add edited. I thought this was already there. Not sure what happened.

Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Copy link
Contributor

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcofranssen
Copy link
Contributor

marcofranssen commented May 17, 2023

I made a suggestion to remove it on the original PR with following explanation.

edited isn't required. That event triggers when the PR descriptions changes. That is an useful event to have a workflow that does stuff with the PR description. In this case we don't need that.

Synchronized is the event we need when new code changes are pushed, that is already there. We can close this PR I think.

For reference see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

@kfox1111
Copy link
Contributor

Ah. yeah. I've seen the runs trigger on title edit. always kind of wondered why. That makes sense.

@faisal-memon
Copy link
Contributor Author

got it, closing this pr.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants