Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

issuer naming should respect issuer_name override #378

Merged
merged 4 commits into from
Aug 2, 2023
Merged

issuer naming should respect issuer_name override #378

merged 4 commits into from
Aug 2, 2023

Conversation

drewwells
Copy link
Contributor 

align the spire-server configmap and issuer CR naming

@drewwells drewwells force-pushed the issuerName branch 3 times, most recently from c6cfe3e to c132550 Compare July 5, 2023 22:13
@drewwells
Copy link
Contributor Author

Added a suffix to the CA issuer object name, so we don't accidentally conflict like I just did on the object names

edwbuck
edwbuck suggested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@edwbuck edwbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't build the compound names in the templates, define new variables in _helper.tpl or _spire_lib.tpl to capture the addition of the suffix to a new variable name, and then use that single definition as the name in the template files that produce YAML.

charts/spire/charts/spire-server/templates/issuer.yaml Show resolved Hide resolved
@drewwells @marcofranssen
issuer naming should respect issuer_name override
a1ec698 
    align the spire-server configmap and issuer CR naming

Signed-off-by: Drew Wells <dwells@infoblox.com>
edwbuck
edwbuck suggested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@edwbuck edwbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes to use issuerName instead of {{spire-server.fullname}}-selfsigned

Can you also do the same for the {{spire-server fullname}}-ca?

charts/spire/charts/spire-server/templates/issuer.yaml Show resolved Hide resolved
@faisal-memon faisal-memon modified the milestones: 0.12.0, 0.11.1 Jul 19, 2023
@faisal-memon
Update configmap
c06057a 
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon
Merge branch 'main' into issuerName
f19893d
@faisal-memon faisal-memon enabled auto-merge (squash) August 2, 2023 19:41
@faisal-memon
Fix wait container
ccc76e4 
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon faisal-memon merged commit d2e1606 into spiffe:main Aug 2, 2023
19 checks passed
faisal-memon added a commit that referenced this pull request Aug 2, 2023
@drewwells @faisal-memon
issuer naming should respect issuer_name override (#378)
b0d9a73 
align the spire-server configmap and issuer CR naming

---------

Signed-off-by: Drew Wells <dwells@infoblox.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Co-authored-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon added a commit that referenced this pull request Aug 2, 2023
@faisal-memon
Bump spire Helm Chart version from 0.11.0 to 0.11.1
b7cf67d 
* d2e1606 issuer naming should respect issuer_name override (#378)
* a2e5c36 Bump test chart dependencies (#416)
* a09e054 support annotations so oidc can be annotated (#391)
* 7d94b10 Update spire to 1.7.1 (#412)
* 9f4d4ac Add aws_pca to the spire-server (#404)
* af13f1f Bump test chart dependencies (#401)
* 9a6768b Add support for disabling container selectors (#399)
* 4687e20 Merge pull request #315 from spiffe/persistence-type
* e16210c Merge branch 'main' into persistence-type
* 624ca9c Remove misadded lockfile (#400)
* 7ce67c6 Bump actions/checkout from 3.5.2 to 3.5.3 (#395)
* b85ba64 Bump helm/kind-action from 1.7.0 to 1.8.0 (#396)
* a6bdb4d Add persistence type flag

Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon added a commit that referenced this pull request Aug 2, 2023
@faisal-memon
Bump spire Helm Chart version from 0.11.0 to 0.11.1
c7b0f16 
* d2e1606 issuer naming should respect issuer_name override (#378)
* a2e5c36 Bump test chart dependencies (#416)
* a09e054 support annotations so oidc can be annotated (#391)
* 7d94b10 Update spire to 1.7.1 (#412)
* 9f4d4ac Add aws_pca to the spire-server (#404)
* af13f1f Bump test chart dependencies (#401)
* 9a6768b Add support for disabling container selectors (#399)
* 4687e20 Merge pull request #315 from spiffe/persistence-type
* e16210c Merge branch 'main' into persistence-type
* 624ca9c Remove misadded lockfile (#400)
* 7ce67c6 Bump actions/checkout from 3.5.2 to 3.5.3 (#395)
* b85ba64 Bump helm/kind-action from 1.7.0 to 1.8.0 (#396)
* a6bdb4d Add persistence type flag

Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon added a commit that referenced this pull request Aug 2, 2023
@faisal-memon
Bump spire Helm Chart version from 0.11.0 to 0.11.1
4b7637e 
* d2e1606 issuer naming should respect issuer_name override (#378)
* a2e5c36 Bump test chart dependencies (#416)
* a09e054 support annotations so oidc can be annotated (#391)
* 7d94b10 Update spire to 1.7.1 (#412)
* 9f4d4ac Add aws_pca to the spire-server (#404)
* af13f1f Bump test chart dependencies (#401)
* 9a6768b Add support for disabling container selectors (#399)
* 4687e20 Merge pull request #315 from spiffe/persistence-type
* e16210c Merge branch 'main' into persistence-type
* 624ca9c Remove misadded lockfile (#400)
* 7ce67c6 Bump actions/checkout from 3.5.2 to 3.5.3 (#395)
* b85ba64 Bump helm/kind-action from 1.7.0 to 1.8.0 (#396)
* a6bdb4d Add persistence type flag

Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon faisal-memon mentioned this pull request Aug 2, 2023
Merged
faisal-memon added a commit that referenced this pull request Aug 2, 2023
@faisal-memon
Bump spire Helm Chart version from 0.11.0 to 0.11.1
6247127 
* d2e1606 issuer naming should respect issuer_name override (#378)
* a09e054 support annotations so oidc can be annotated (#391)
* 7d94b10 Update spire to 1.7.1 (#412)
* 9a6768b Add support for disabling container selectors (#399)
* 624ca9c Remove misadded lockfile (#400)

Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon added a commit that referenced this pull request Aug 3, 2023
@faisal-memon
Bump spire Helm Chart version from 0.11.0 to 0.11.1 (#419)
1e3039c 
Please review the below changelog to ensure this matches up with the
semantic version being applied.

**Note**: As this is a patch release we will make a cherry-picked
release using a followup PR targetering the release branch. Will
cherrypick the following commits into this patch release + the commit
bumping this version number.

**Changes in this release**

* d2e1606 issuer naming should respect issuer_name override (#378)
* a09e054 support annotations so oidc can be annotated (#391)
* 7d94b10 Update spire to 1.7.1 (#412)
* 9a6768b Add support for disabling container selectors (#399)
* 624ca9c Remove misadded lockfile (#400)

Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon added a commit that referenced this pull request Aug 3, 2023
@faisal-memon
Bump spire Helm Chart version from 0.11.0 to 0.11.1 (#419)
431d77f 
Please review the below changelog to ensure this matches up with the
semantic version being applied.

**Note**: As this is a patch release we will make a cherry-picked
release using a followup PR targetering the release branch. Will
cherrypick the following commits into this patch release + the commit
bumping this version number.

**Changes in this release**

* d2e1606 issuer naming should respect issuer_name override (#378)
* a09e054 support annotations so oidc can be annotated (#391)
* 7d94b10 Update spire to 1.7.1 (#412)
* 9a6768b Add support for disabling container selectors (#399)
* 624ca9c Remove misadded lockfile (#400)

Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon faisal-memon mentioned this pull request Aug 3, 2023
Merged
marcofranssen added a commit that referenced this pull request Aug 18, 2023
@marcofranssen
Bump spire Helm Chart version from 0.11.1 to 0.12.0
4e3103f 
* 5e2e8a9 Adds AWS KMS KeyManager support (#435)
* 77fe43f Cron job to check for and update images (#249)
* b7e1525 Allow job hooks to be disabled (#434)
* 5e4cf6f Clarify project issues identified with nesting document (#450)
* 7289351 Update spire bits to 1.7.2 (#452)
* dc8a454 Array spacing in values is incorrect in a file. (#451)
* 94326d9 Fixup Helm docs
* ae8941c Support Nested Spire with External Agent (#117)
* f40743d Improve Tornjak documentation (#439)
* 0124f63 Bypass example-test for docs only changes (#449)
* 48a2898 Fix chainguard image references as per issue 442 (#443)
* bd393e9 Bump test chart dependencies (#445)
* a52818a Add a FAQ and switch rare issue from README to it (#437)
* e60f528 option to set KeyManager memory in spire server (#444)
* a167ce6 Bump actions/setup-go from 4.0.1 to 4.1.0
* e774584 Bump test chart dependencies (#426)
* bfec27e Fix jwtIssuer to allow for Uris including scheme (#425)
* 7a6e4f8 Change Tornjak backend default port (#436)
* 1e3039c Bump spire Helm Chart version from 0.11.0 to 0.11.1 (#419)
* d2e1606 issuer naming should respect issuer_name override (#378)
* a2e5c36 Bump test chart dependencies (#416)
* a09e054 support annotations so oidc can be annotated (#391)
* 7d94b10 Update spire to 1.7.1 (#412)
* 9f4d4ac Add aws_pca to the spire-server (#404)
* af13f1f Bump test chart dependencies (#401)
* 9a6768b Add support for disabling container selectors (#399)
* 4687e20 Merge pull request #315 from spiffe/persistence-type
* e16210c Merge branch 'main' into persistence-type
* 624ca9c Remove misadded lockfile (#400)
* 7ce67c6 Bump actions/checkout from 3.5.2 to 3.5.3 (#395)
* b85ba64 Bump helm/kind-action from 1.7.0 to 1.8.0 (#396)
* a6bdb4d Add persistence type flag

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
@marcofranssen marcofranssen mentioned this pull request Aug 18, 2023
Merged
faisal-memon pushed a commit that referenced this pull request Aug 21, 2023
@marcofranssen
Bump spire Helm Chart version from 0.11.1 to 0.12.0 (#455)
8e9d42a 
Please review the below changelog to ensure this matches up with the
semantic version being applied.

> **Note**: **Maintainers** ensure to run following after merging this
PR to trigger the release workflow:
>
> ```shell
> git checkout main
> git pull
> git checkout release
> git pull
> git merge main
> git push
> ```

**Changes in this release**

* 5e2e8a9 Adds AWS KMS KeyManager support (#435)
* 77fe43f Cron job to check for and update images (#249)
* b7e1525 Allow job hooks to be disabled (#434)
* 5e4cf6f Clarify project issues identified with nesting document
(#450)
* 7289351 Update spire bits to 1.7.2 (#452)
* dc8a454 Array spacing in values is incorrect in a file. (#451)
* 94326d9 Fixup Helm docs
* ae8941c Support Nested Spire with External Agent (#117)
* f40743d Improve Tornjak documentation (#439)
* 0124f63 Bypass example-test for docs only changes (#449)
* 48a2898 Fix chainguard image references as per issue 442 (#443)
* bd393e9 Bump test chart dependencies (#445)
* a52818a Add a FAQ and switch rare issue from README to it (#437)
* e60f528 option to set KeyManager memory in spire server (#444)
* a167ce6 Bump actions/setup-go from 4.0.1 to 4.1.0
* e774584 Bump test chart dependencies (#426)
* bfec27e Fix jwtIssuer to allow for Uris including scheme (#425)
* 7a6e4f8 Change Tornjak backend default port (#436)
* 1e3039c Bump spire Helm Chart version from 0.11.0 to 0.11.1 (#419)
* d2e1606 issuer naming should respect issuer_name override (#378)
* a2e5c36 Bump test chart dependencies (#416)
* a09e054 support annotations so oidc can be annotated (#391)
* 7d94b10 Update spire to 1.7.1 (#412)
* 9f4d4ac Add aws_pca to the spire-server (#404)
* af13f1f Bump test chart dependencies (#401)
* 9a6768b Add support for disabling container selectors (#399)
* 4687e20 Merge pull request #315 from spiffe/persistence-type
* e16210c Merge branch 'main' into persistence-type
* 624ca9c Remove misadded lockfile (#400)
* 7ce67c6 Bump actions/checkout from 3.5.2 to 3.5.3 (#395)
* b85ba64 Bump helm/kind-action from 1.7.0 to 1.8.0 (#396)
* a6bdb4d Add persistence type flag

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
@kfox1111 kfox1111 mentioned this pull request May 20, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kfox1111 kfox1111 kfox1111 left review comments

@faisal-memon faisal-memon faisal-memon approved these changes

@edwbuck edwbuck edwbuck approved these changes

@marcofranssen marcofranssen Awaiting requested review from marcofranssen

@developer-guy developer-guy Awaiting requested review from developer-guy

@dfeldman dfeldman Awaiting requested review from dfeldman

@mrsabath mrsabath Awaiting requested review from mrsabath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drewwells @kfox1111 @faisal-memon @edwbuck