Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#261 Remove NodeResolver links from docs. #262

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

idexter
Copy link

@idexter idexter commented Nov 15, 2022

Because it has been deprecated and removed in v1.5.0.

@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for spiffe ready!

Name Link
🔨 Latest commit 6ac32a6
🔍 Latest deploy log https://app.netlify.com/sites/spiffe/deploys/6373ce9d4b6db50009602bcc
😎 Deploy Preview https://deploy-preview-262--spiffe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Because it has been deprecated and removed in [v1.5.0](https://github.com/spiffe/spire/releases/tag/v1.5.0).

Signed-off-by: Anton Kucherov <idexter.ru@gmail.com>
Signed-off-by: Anton Kucherov <idexter.ru@gmail.com>
@@ -84,7 +82,7 @@ This bootstrap bundle is a default configuration, and should be replaced with cu
{{< /warning >}}
8. The server calls the AWS API to validate the proof.
9. AWS acknowledges the document is valid.
10. The server performs node resolution, to verify additional properties about the agent node and update its registration entries accordingly. For example, if the node was attested using Microsoft Azure Managed Service Identity (MSI). The resolver extracts the Tenant ID and Principal ID from the agent SPIFFE ID and uses the various Azure services to get information for building an additional set of selectors.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about section 10. How to change it properly or where to move it:

The server performs node resolution...

@evan2645
Copy link
Member

Fixes #263

This was referenced Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants