Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: nil pointer dereference when allow_unsafe_ids is configured #2476

Closed
yangmarcyang opened this issue Aug 31, 2021 · 0 comments · Fixed by #2477
Closed

Bug: nil pointer dereference when allow_unsafe_ids is configured #2476

yangmarcyang opened this issue Aug 31, 2021 · 0 comments · Fixed by #2477

Comments

@yangmarcyang
Copy link
Contributor

Hello there, nil pointer dereference issue is encountered when allow_unsafe_ids is configured in server.conf. The root cause is that in NewServerConfig of cmd/spire-server/cli/run/run.go, sc.Log is called before its initialization.

It can be fixed by simply moving the logger initialization up. I will create a PR for that.
yangmarcyang added a commit to yangmarcyang/spire that referenced this issue Aug 31, 2021
@yangmarcyang
Fix nil pointer dereference when allow_unsafe_ids is configured (spif…
9c6aacd 
…fe#2476)

Change-Id: I9200600b251e2f51be7277104112222f92964265
Signed-off-by: Marc Yang <marc.yang@bytedance.com>
@yangmarcyang yangmarcyang mentioned this issue Aug 31, 2021
Merged
azdagron pushed a commit that referenced this issue Aug 31, 2021
@yangmarcyang
Fix nil pointer dereference when allow_unsafe_ids is configured (#2476)…
d4daee2 
… (#2477)

Signed-off-by: Marc Yang <marc.yang@bytedance.com>
evan2645 pushed a commit to evan2645/spire that referenced this issue Sep 2, 2021
@yangmarcyang @evan2645
Fix nil pointer dereference when allow_unsafe_ids is configured (spif…
b089668 
…fe#2476) (spiffe#2477)

Signed-off-by: Marc Yang <marc.yang@bytedance.com>
evan2645 pushed a commit that referenced this issue Sep 2, 2021
@yangmarcyang @evan2645
Fix nil pointer dereference when allow_unsafe_ids is configured (#2476)…
1246b07 
… (#2477)

Signed-off-by: Marc Yang <marc.yang@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix nil pointer dereference when allow_unsafe_ids is configured (#2476) yangmarcyang/spire
1 participant
@yangmarcyang