Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cli printer server entry commands #3628

Merged

Conversation

guilhermocc
Copy link
Contributor

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality 🤔
The following spire-server entry commands are affected:

  • count
  • create
  • delete
  • show
  • update

Description of change ✍️
Enable output format definition for spire-server entry commands, using cliprinter.

Which issue this PR fixes
Ongoing work for #1354

…mand

Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
@guilhermocc guilhermocc force-pushed the use-cli-printer-server-entry-commands branch from 6009317 to 62b62a5 Compare November 21, 2022 18:30
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
@guilhermocc guilhermocc force-pushed the use-cli-printer-server-entry-commands branch from 6788a94 to 8512b7e Compare November 21, 2022 18:50
@amartinezfayo amartinezfayo added this to the 1.5.2 milestone Nov 23, 2022
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I only have one small suggestion that may be good to apply now since it will require a modification in all the commands.

cmd/spire-server/cli/entry/create.go Outdated Show resolved Hide resolved
guilhermocc and others added 3 commits November 24, 2022 11:40
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @guilhermocc!

@amartinezfayo amartinezfayo merged commit 3d4c8a2 into spiffe:main Nov 24, 2022
stevend-uber pushed a commit to stevend-uber/spire that referenced this pull request Oct 16, 2023
* Use cliprinter to enable more output format options in list agent command

Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants