run tests with `-race` #72

boz · 2017-08-25T03:21:10Z

To detect possible race conditions.

edit: i usually have two modes - one quick without -race for edit-test cycle, one with -race for CI and occasionally running by hand.

The text was updated successfully, but these errors were encountered:

* refactor: removed intermediate variables for error messages Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: changed log lines Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: refactored SelectorValuesFromSignature returns and vars Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed trailing comma from log line Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved from nil testing to len testing Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: minor fixes to getSignatureSubject Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed newline Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br>

* refactor: removed intermediate variables for error messages Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: changed log lines Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: refactored SelectorValuesFromSignature returns and vars Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed trailing comma from log line Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved from nil testing to len testing Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: minor fixes to getSignatureSubject Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed newline Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* refactor: removed intermediate variables for error messages Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: changed log lines Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: refactored SelectorValuesFromSignature returns and vars Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed trailing comma from log line Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved from nil testing to len testing Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: minor fixes to getSignatureSubject Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed newline Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>

* Clarify the One-SPIFFE-ID-Per-SVID rule From the very first version of the X.509-SVID specification, a requirement has been set that an SVID may contain one and only one SPIFFE ID. Users requiring more than one identity must use multiple SVIDs, as opposed to a single SVID representing multiple identities. SIG-Spec has re-visited this restriction. After a lengthy discussion, consensus was reached that the rule should stand. There were two primary concerns in relaxing this restriction: 1) Audit logging would become more difficult, as an authenticator would have to understand which identity is the one that was in fact authorized, and 2) authorization would become more difficult, and SPIFFE is not in a position to provide authorization instructions with regards to how policies governing multiple SPIFFE IDs should be combined. It was acknowledged that it would be useful to include multiple SPIFFE IDs in the context of a server certificate, however workloads may choose to use the same SVID as both server and client certificates, and the complexity introduced in allowing such a concession was decidedly more dangerous than simply keeping the restriction in place. This commit: 1. Updates the text to give a short explanation on the existence of the restriction 1. Updates the text to specify what a validator should do when encountering multiple SPIFFE IDs in an SVID 1. Clarifies SVID validation of signing certificates 1. Fixes spiffe#32 Signed-off-by: Evan Gilman <egilman@vmware.com>

boz mentioned this issue Aug 27, 2017

testing: check for race conditions #84

Merged

y2bishop2y closed this as completed in #84 Aug 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

run tests with `-race` #72

run tests with `-race` #72

boz commented Aug 25, 2017 •

edited

Loading

run tests with -race #72

run tests with -race #72

Comments

boz commented Aug 25, 2017 • edited Loading

run tests with `-race` #72

run tests with `-race` #72

boz commented Aug 25, 2017 •

edited

Loading