Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server CA plugin: revisit validation logic in LoadCertificate() #99

Closed
amartinezfayo opened this issue Aug 31, 2017 · 0 comments
Closed

Server CA plugin: revisit validation logic in LoadCertificate() #99

amartinezfayo opened this issue Aug 31, 2017 · 0 comments

Comments

@amartinezfayo
Copy link
Member

Instead of doing a complete validation to ensure that the certificate being loaded is a valid signing certificate, we may just validate that the certificate being loaded was created based on a CSR generated by the plugin.
This was referenced Aug 31, 2017
Merged
Closed
rodrigolc pushed a commit to rodrigolc/spire that referenced this issue Sep 15, 2022
@willallves
Removed unnecessary code (spiffe#99)
826cc9d 
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
rodrigolc pushed a commit to rodrigolc/spire that referenced this issue Oct 14, 2022
@willallves
Removed unnecessary code (spiffe#99)
3eccd43 
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
rodrigolc pushed a commit to rodrigolc/spire that referenced this issue Oct 17, 2022
@willallves
Removed unnecessary code (spiffe#99)
5b90dbd 
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
rodrigolc pushed a commit to rodrigolc/spire that referenced this issue Oct 25, 2022
@willallves @matheusdefarias
Removed unnecessary code (spiffe#99)
ef0584d 
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>
rodrigolc pushed a commit to rodrigolc/spire that referenced this issue Nov 21, 2022
@willallves @matheusdefarias
Removed unnecessary code (spiffe#99)
09d16b4 
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>
rodrigolc pushed a commit to rodrigolc/spire that referenced this issue Dec 6, 2022
@willallves @rodrigolc
Removed unnecessary code (spiffe#99)
b5d735a 
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>
rodrigolc pushed a commit to rodrigolc/spire that referenced this issue Dec 7, 2022
@willallves @rodrigolc
Removed unnecessary code (spiffe#99)
32f8b06 
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>
ajessup pushed a commit to ajessup/spire that referenced this issue Feb 1, 2023
@evan2645
Merge pull request spiffe#99 from yinonavraham/patch-1
b91a8b0 
Fix typo in ToC - JOSE Header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evan2645 @amartinezfayo