api-refactor: SVID API service definition #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
marcosy
as code owners
| // used if unset. The TTL is advisory only. The actual lifetime of the | ||
| // X509-SVID may be lower depending on the remaining lifetime of the active | ||
| // SPIRE Server CA. | ||
| int32 ttl = 3; |
There was a problem hiding this comment.
The field number should be 2?
|
Yes, yes it should :) Thanks. |
This is the definition for the SVID API in the Server API refactor. This is not set in stone and some decisions actively in discussion are sure to change this, albeit superficially. I'm introducing this now so we can kick off development. This API was a good candidate since it was 1) very small and focused, 2) not likely to change much as the API solidifies, 3) uses a broad range of SPIRE internals to do its job. Developing this API will help establish patterns and practices that should be applicable to other API development. Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
azdagron
force-pushed
the
api-refactor-svid-api-definition
branch
from
cbf627f
to
28df360
Compare
amartinezfayo
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the definition for the SVID API in the Server API refactor. This is not set in stone and some decisions actively in discussion are sure to change this, albeit superficially.
I'm introducing this now so we can kick off development. This API was a good candidate since it was:
Developing this API will help establish patterns and practices that should be applicable to other API development.