Bring in the rest of the API refactor proto and service definitions #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
mcpherrinm
as code owners
| message AttestAgentResponse { | ||
| message Result { | ||
| // The agent X509-SVID. | ||
| spire.types.X509SVID identity = 1; |
There was a problem hiding this comment.
We name this as svid in other messages. Do you think that identity is a better choice here?
I'm just looking from a consistency point of view.
Comment on lines
165
to
175
| // Required. How long until the token expires (in seconds). | ||
| int32 ttl = 3; | ||
|
|
||
| // An optional token value to use for the token. Must be unique. If unset, | ||
| // the server will generate a value. | ||
| string token = 1; | ||
|
|
||
| // An optional SPIFFE ID to assign to the agent beyond that given by | ||
| // join token attestation. If set, this results in an entry being created | ||
| // that maps the attestation assigned agent ID to this ID. | ||
| spire.types.SPIFFEID agent_id = 2; |
There was a problem hiding this comment.
nit: follow the same order as the field number
Suggested change
| // Required. How long until the token expires (in seconds). | |
| int32 ttl = 3; | |
| // An optional token value to use for the token. Must be unique. If unset, | |
| // the server will generate a value. | |
| string token = 1; | |
| // An optional SPIFFE ID to assign to the agent beyond that given by | |
| // join token attestation. If set, this results in an entry being created | |
| // that maps the attestation assigned agent ID to this ID. | |
| spire.types.SPIFFEID agent_id = 2; | |
| // An optional token value to use for the token. Must be unique. If unset, | |
| // the server will generate a value. | |
| string token = 1; | |
| // An optional SPIFFE ID to assign to the agent beyond that given by | |
| // join token attestation. If set, this results in an entry being created | |
| // that maps the attestation assigned agent ID to this ID. | |
| spire.types.SPIFFEID agent_id = 2; | |
| // Required. How long until the token expires (in seconds). | |
| int32 ttl = 3; |
- rename `identity` field to `svid` in the AttestAgent response - remove language around "canonical identity" - fix field ordering on CreateJoinTokenRequest Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the rest of the protobufs from the server API refactor branch in preparation for starting the work.
I would have merged that branch directly but there were some small updates in master that weren't backported.