Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Refactor: Add Bundle.PublishJWTAuthority RPC stub #1585

Merged
merged 1 commit into from
May 27, 2020

Conversation

azdagron
Copy link
Member

This adds in the definition and stub implementation of the Bundle.PublishJWTAuthority RPC as discussed in the commentary on issue #1550

This RPC will be used exclusively by downstream SPIRE servers to publish JWT authorities upstream. The AppendBundle RPC will be used to administratively append material to the SPIRE server bundle, which is not propogated upstream.

Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azdagron azdagron merged commit 1101598 into spiffe:master May 27, 2020
@azdagron azdagron added this to To do in Server API Refactors May 29, 2020
@azdagron azdagron deleted the publish-jwt-authority-rpc-stub branch May 29, 2020 21:55
@amartinezfayo amartinezfayo moved this from To do to Done in Server API Refactors Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants