API Refactor: Downstream and Admin authorizers #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These authorizers authorize the caller as a downstream or admin workload by looking up the registration entries matching the caller ID. They attach the respective downstream or admin entries to the context. These authorizers use a helper to obtain the entries for the caller that uses the context to cache retrieved entries. This prevents the entry lookup from happening more than once if these authorizers are used for the same RPC (e.g., via AuthorizeAnyOf). Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
mcpherrinm
as code owners
azdagron
changed the title
pkg/server/api/middleware/entries.go
Outdated
|
|
||
| type callerEntriesKey struct{} | ||
|
|
||
| // WithCallerEntries returns a the caller entries retrieved using the given |
There was a problem hiding this comment.
Suggested change
| // WithCallerEntries returns a the caller entries retrieved using the given | |
| // WithCallerEntries returns the caller entries retrieved using the given |
amartinezfayo
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These authorizers authorize the caller as a downstream or admin workload by looking up the registration entries matching the caller ID.
They attach the respective downstream or admin entries to the context.
These authorizers use a helper to obtain the entries for the caller that uses the context to cache retrieved entries. This prevents the entry lookup from happening more than once if these authorizers are used for the same RPC (e.g., via AuthorizeAnyOf).