Api Refactor: implements BatchDeleteEntry rpc #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosDY
requested review from
amartinezfayo,
APTy,
azdagron,
evan2645 and
mcpherrinm
as code owners
MarcosDY
changed the title
pkg/server/api/entry/v1/service.go
Outdated
| log.WithError(err).Error("Failed to delete entry") | ||
| return &entry.BatchDeleteEntryResponse_Result{ | ||
| Id: id, | ||
| Status: api.CreateStatus(codes.Internal, "failed to delete entry"), |
There was a problem hiding this comment.
Error information is missing here
azdagron
reviewed
Jun 9, 2020
pkg/server/api/entry/v1/service.go
Outdated
| func (s *Service) deleteEntry(ctx context.Context, id string) *entry.BatchDeleteEntryResponse_Result { | ||
| log := rpccontext.Logger(ctx) | ||
|
|
||
| if len(id) == 0 { |
There was a problem hiding this comment.
nit: == "" is more idiomatic for checking for an empty string
pkg/server/api/entry/v1/service.go
Outdated
Comment on lines
106
to
122
| cEntry, err := s.ds.FetchRegistrationEntry(ctx, &datastore.FetchRegistrationEntryRequest{ | ||
| EntryId: id, | ||
| }) | ||
| if err != nil { | ||
| log.WithError(err).Error("Failed to fetch entry") | ||
| return &entry.BatchDeleteEntryResponse_Result{ | ||
| Id: id, | ||
| Status: api.CreateStatus(codes.Internal, "failed to fetch entry: %v", err), | ||
| } | ||
| } | ||
| if cEntry.Entry == nil { | ||
| log.Error("Invalid request: entry not found") | ||
| return &entry.BatchDeleteEntryResponse_Result{ | ||
| Id: id, | ||
| Status: api.CreateStatus(codes.NotFound, "entry not found"), | ||
| } | ||
| } |
There was a problem hiding this comment.
The datastore is already supposed to handle failing if the entry does not already exist but I think it is broken and returns a code.Unknown status. We should fix the datastore to return codes.NotFound if the entry doesn't exist.
azdagron
previously approved these changes
Jun 9, 2020
Signed-off-by: Marcos Yacob <marcos@scytale.io>
MarcosDY
force-pushed
the
api-refactor-impl-delete-entry
branch
from
14e93bf
to
f5b5e7b
Compare
azdagron
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Batch delete entry rpc
Which issue this PR fixes
fixes #1602