API Refactor: Implement Entry.ListEntries RPC #1598 #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunzimariano
requested review from
amartinezfayo,
APTy,
azdagron,
evan2645 and
mcpherrinm
as code owners
MarcosDY
reviewed
Jun 9, 2020
azdagron
reviewed
Jun 10, 2020
kunzimariano
force-pushed
the
api_refactor_entry_listentries_1598
branch
3 times, most recently
from
05e0aa0
to
b057c98
Compare
azdagron
reviewed
Jun 11, 2020
azdagron
reviewed
Jun 11, 2020
pkg/server/api/entry/v1/service.go
Outdated
Comment on lines
312
to
315
| var dsSelectors []*common.Selector | ||
| for _, reqSelector := range req.Filter.BySelectors.Selectors { | ||
| s := &common.Selector{ | ||
| Type: reqSelector.Type, | ||
| Value: reqSelector.Value, | ||
| } | ||
| dsSelectors = append(dsSelectors, s) | ||
| } |
There was a problem hiding this comment.
Maybe this can go into an api.SelectorsFromProto that also does the selector type and value validation that we have done elsewhere?
There was a problem hiding this comment.
Absolutely! Giving these are selectors, I suppose it should go under common and not server.
There was a problem hiding this comment.
The api package is where we've been putting that stuff, since for now, these new types are only part of the server API.
Signed-off-by: Mariano Kunzi <kunzi.mariano@gmail.com>
Signed-off-by: Mariano Kunzi <kunzi.mariano@gmail.com>
kunzimariano
force-pushed
the
api_refactor_entry_listentries_1598
branch
from
b057c98
to
75d76ac
Compare
Signed-off-by: Mariano Kunzi <kunzi.mariano@gmail.com>
kunzimariano
force-pushed
the
api_refactor_entry_listentries_1598
branch
from
75d76ac
to
454d400
Compare
|
DCO status is wedged. I've reviewed DCO on the commits though and I think we're good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Refactor: Implement Entry.ListEntries RPC
fixes #1598
Signed-off-by: Mariano Kunzi kunzi.mariano@gmail.com