Api Refactor: Implement List Agents #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosDY
requested review from
amartinezfayo,
APTy,
azdagron,
evan2645 and
mcpherrinm
as code owners
MarcosDY
force-pushed
the
api-refactor-list-agents
branch
from
139da8b
to
ce7d1f0
Compare
marcosy
reviewed
Jun 25, 2020
| Id: ProtoFromID(spiffeID), | ||
| X509SvidExpiresAt: n.CertNotAfter, | ||
| X509SvidSerialNumber: n.CertSerialNumber, | ||
| Banned: n.CertSerialNumber == "", |
There was a problem hiding this comment.
I added a function to detect if an agent is banned or not in the BanAgent PR.
If that PR get merged first, maybe we could use that method here: nodeutil.IsAgentBanned(...)
There was a problem hiding this comment.
yes, I was waiting for that merge to use it
| tx, err = applyPagination(p, tx) | ||
| func listAttestedNodes(ctx context.Context, db *sqlDB, req *datastore.ListAttestedNodesRequest) (*datastore.ListAttestedNodesResponse, error) { | ||
| if req.Pagination != nil && req.Pagination.PageSize == 0 { | ||
| return nil, status.Error(codes.InvalidArgument, "cannot paginate with pagesize = 0") |
There was a problem hiding this comment.
Suggested change
| return nil, status.Error(codes.InvalidArgument, "cannot paginate with pagesize = 0") | |
| return nil, status.Error(codes.InvalidArgument, "cannot paginate with zero length page size") |
There was a problem hiding this comment.
we have the same message for all pagination uses, may we update all of them?
azdagron
previously approved these changes
Jun 26, 2020
| _, err = s.ds.CreateAttestedNode(ctx, &datastore.CreateAttestedNodeRequest{Node: aNode5}) | ||
| s.Require().NoError(err) | ||
|
|
||
| aNode1WithSelectors := proto.Clone(aNode1).(*common.AttestedNode) |
There was a problem hiding this comment.
nit: add helper function to clone attested node. It minimizes the number of type assertions one has to look at :)
|
Thanks for taking this on @MarcosDY :) That SQL plugin is a monster to work with :) |
- Implement list agent - Refactor datastore.ListAttestedNodes to allow filtering and returns selectors on demand. Signed-off-by: Marcos Yacob <marcos@scytale.io>
MarcosDY
force-pushed
the
api-refactor-list-agents
branch
from
a904b07
to
88ae22c
Compare
azdagron
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectors on demand.
Which issue this PR fixes
fixes #1634