API Refactor: Implement CreateJoinToken #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfeldman
requested review from
amartinezfayo,
APTy,
azdagron,
evan2645 and
mcpherrinm
as code owners
dfeldman
changed the title
azdagron
reviewed
Jun 26, 2020
azdagron
reviewed
Jun 30, 2020
azdagron
reviewed
Jul 1, 2020
|
I'll go ahead and squash this soon |
Signed-off-by: Daniel Feldman <daniel@scytale.io>
dfeldman
force-pushed
the
createjointoken-3
branch
from
6d676dc
to
f0ada9e
Compare
azdagron
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Feldman daniel@scytale.io
Pull Request check list
Affected functionality
Implements the CreateJoinToken API as part of the API refactor
Description of change
This is pretty much identical to the old version of CreateJoinToken, just in the new API framework.
Which issue this PR fixes
Fixes #1640