API refactor: add attested nodes query tests #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Yacob <marcos@scytale.io>
MarcosDY
requested review from
amartinezfayo,
APTy,
azdagron,
evan2645 and
mcpherrinm
as code owners
| func TestListAttestedNodesQuery(t *testing.T) { | ||
| for _, tt := range []struct { | ||
| dialect string | ||
| paged string |
There was a problem hiding this comment.
maybe having paged defined as a type is a better fit for this?
type paged int
const (
no paged = iota
withToken
withNoToken
)
| expiresBefore := time.Now().Unix() | ||
| t.Run(name, func(t *testing.T) { | ||
| req := new(datastore.ListAttestedNodesRequest) | ||
| switch tt.paged { |
There was a problem hiding this comment.
I think that this switch could be more clear if it's done through a custom type.
| Token: "2", | ||
| } | ||
| default: | ||
| require.FailNow(t, "unsupported page case: %q", tt.paged) |
There was a problem hiding this comment.
FailNowf should be used when using format strings.
| req.FetchSelectors = true | ||
|
|
||
| default: | ||
| require.FailNow(t, "unsupported by case: %q", by) |
There was a problem hiding this comment.
FailNowf should be used when using format strings.
| Token: "2", | ||
| } | ||
| default: | ||
| require.FailNow(t, "unsupported page case: %q", tt.paged) |
There was a problem hiding this comment.
nit: unsupported paged case
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
|
CI/CD and DCO passed but it looks like there was a hiccup with notifications. Merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to validate attested nodes query