API refactor: implements delete agent rpc #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
MarcosDY
requested review from
amartinezfayo,
APTy,
azdagron,
evan2645 and
mcpherrinm
as code owners
azdagron
reviewed
Jul 1, 2020
pkg/server/api/agent/v1/service.go
Outdated
| return nil, status.Error(codes.NotFound, "agent not found") | ||
| default: | ||
| log.WithError(err).Error("Failed to remove Agent") | ||
| return nil, status.Errorf(codes.Internal, "failed to remove Agent: %v", err) |
There was a problem hiding this comment.
Suggested change
| return nil, status.Errorf(codes.Internal, "failed to remove Agent: %v", err) | |
| return nil, status.Errorf(codes.Internal, "failed to remove agent: %v", err) |
pkg/server/api/agent/v1/service.go
Outdated
| log.WithError(err).Error("Agent not found") | ||
| return nil, status.Error(codes.NotFound, "agent not found") | ||
| default: | ||
| log.WithError(err).Error("Failed to remove Agent") |
There was a problem hiding this comment.
Suggested change
| log.WithError(err).Error("Failed to remove Agent") | |
| log.WithError(err).Error("Failed to remove agent") |
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
marcosy
reviewed
Jul 1, 2020
| ds: ds, | ||
| logHook: logHook, | ||
| } | ||
| if tt.dsError != nil { |
There was a problem hiding this comment.
nit: we could remove the if and just setting a nil next error
| err: "not an agent ID", | ||
| req: &agentpb.DeleteAgentRequest{ | ||
| Id: &types.SPIFFEID{ | ||
| TrustDomain: "examples.org", |
There was a problem hiding this comment.
Suggested change
| TrustDomain: "examples.org", | |
| TrustDomain: "example.org", |
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements delete agent rpc, and update delete attested node on datastore to remove relationships
Which issue this PR fixes
fixes #1636