Remove support for deprecated UpstreamCA #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes support for the UpstreamCA plugin, which was deprecated in favor of the UpstreamAuthority plugin in 0.10.0. Also removes the server catalog unit-test which only tested deprecation behavior for UpstreamCA. A new unit-test that covers the catalog behavior will be added separately. Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
azdagron
requested review from
ajessup,
amartinezfayo,
APTy,
evan2645 and
mcpherrinm
as code owners
azdagron
changed the title
|
|
||
| const ( | ||
| // TODO: Replace with your plugin name. This will be used by the catalog | ||
| // to identify your plugin. Plugin names don't usually contain the plugin |
There was a problem hiding this comment.
Suggested change
| // to identify your plugin. Plugin names don't usually contain the plugin | |
| // to identify your plugin. Plugin names don't usually contain the plugin type |
| // This RPC is optional and will return NotImplemented if unsupported. | ||
| // | ||
| // Implementation note: | ||
| // The stream should be kept open open in the face of transient errors |
There was a problem hiding this comment.
Suggested change
| // The stream should be kept open open in the face of transient errors | |
| // The stream should be kept open in the face of transient errors |
There was a problem hiding this comment.
This is also in the upstreamauthority.proto. I'll fix both.
|
I fixed them up as part of this PR but rolled the change back. The two configs are no longer in use (they were part of an HA playground that is no longer around). I was about to open up a PR to remove them. |
Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
amartinezfayo
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for the UpstreamCA plugin, which was deprecated in favor of the UpstreamAuthority plugin in 0.10.0.
Also removes the server catalog unit-test which only tested deprecation behavior for UpstreamCA. A new unit-test that covers the catalog behavior will be added separately.