Fail to start server/agent on unknown config #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
mcpherrinm
as code owners
| l.WithFields(logrus.Fields{ | ||
| "section": section, | ||
| "keys": strings.Join(keys, ","), | ||
| }).Error("Unknown configuration detected") |
There was a problem hiding this comment.
Since this effectively terminates the program, we may use the fatal level?
Suggested change
| }).Error("Unknown configuration detected") | |
| }).Fatal("Unknown configuration detected") |
| l.WithFields(logrus.Fields{ | ||
| "section": section, | ||
| "keys": strings.Join(keys, ","), | ||
| }).Error("Unknown configuration detected") |
There was a problem hiding this comment.
Since this effectively terminates the program, we may use the fatal level?
Suggested change
| }).Error("Unknown configuration detected") | |
| }).Fatal("Unknown configuration detected") |
| @@ -24,6 +24,16 @@ func AssertLogs(t *testing.T, entries []*logrus.Entry, expected []LogEntry) { | |||
| assert.Equal(t, expected, convertLogEntries(entries), "unexpected logs") | |||
| } | |||
|
|
|||
| func AssertLogsAnyOrder(t *testing.T, entries []*logrus.Entry, expected []LogEntry) { | |||
amartinezfayo
previously approved these changes
Jul 8, 2020
|
Actually, we don't want Fatal. It calls os.Exit(). I'm going to change it back to Error level. I'll also squash and rebase. |
Also allows for consumers who are extending the CLI to opt-out of the unknown configuration check. Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
azdagron
force-pushed
the
bail-on-unknown-config
branch
from
e746a4c
to
91bc363
Compare
amartinezfayo
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allows for consumers who are extending the CLI to opt-out of the unknown configuration check.
Fixes #1101, fixes #1432