Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use revision_number to detect reg entry changes #1720

Conversation

marcosy
Copy link
Contributor

@marcosy marcosy commented Jul 9, 2020

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality

Registration entries

Description of change

This PR makes the agent to use the revision_number to detect changes in the registration entries instead of entry fields inspection.

Which issue this PR fixes

Fixes: #1717

Signed-off-by: Marcos Yedro marcosyedro@gmail.com

Signed-off-by: Marcos Yedro <marcosyedro@gmail.com>
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azdagron azdagron merged commit 9a6870b into spiffe:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use entry revision number to detect changes
3 participants