Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Refactor: Add ITs for downstream RPCs #1733

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

MarcosDY
Copy link
Collaborator

Add ITs to validate access to downstream RPCs

Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
I have some minor suggestions.

test/integration/setup/downstreamclient/client.go Outdated Show resolved Hide resolved
test/integration/setup/downstreamclient/client.go Outdated Show resolved Hide resolved
test/integration/setup/downstreamclient/client.go Outdated Show resolved Hide resolved
test/integration/setup/downstreamclient/client.go Outdated Show resolved Hide resolved
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
@MarcosDY MarcosDY force-pushed the api-refactor-downstream-its branch from 719c11d to e9ca54b Compare July 23, 2020 15:44
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarcosDY!

@amartinezfayo amartinezfayo merged commit 5743b4b into spiffe:master Jul 23, 2020
@MarcosDY MarcosDY deleted the api-refactor-downstream-its branch August 2, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants