API Refactor: switch agent to use new server APIs #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
mcpherrinm
as code owners
azdagron
commented
Aug 12, 2020
| @@ -7,6 +7,8 @@ import ( | |||
| "crypto/rand" | |||
| "crypto/tls" | |||
| "crypto/x509" | |||
| "errors" | |||
There was a problem hiding this comment.
This file is mostly a renamed version of experimental_test.go.
azdagron
commented
Aug 12, 2020
| Bundles map[string]*common.Bundle | ||
| } | ||
|
|
||
| func (u *Update) String() string { |
There was a problem hiding this comment.
This function is not really used. The cache implementation already has rich logging of the changes to entries and such.
azdagron
commented
Aug 12, 2020
| @@ -65,19 +63,20 @@ func (r *rotator) Run(ctx context.Context) error { | |||
|
|
|||
| func (r *rotator) runRotation(ctx context.Context) error { | |||
| for { | |||
| if err := r.rotateSVID(ctx); err != nil { | |||
There was a problem hiding this comment.
This change causes the rotator to evaluate the SVID for rotation right when Run is executed instead of waiting for the initial period (1.5s). The resolved a flaky unit-test and shouldn't have any real impact on production behavior as far as I can tell.
amartinezfayo
previously approved these changes
Aug 13, 2020
pkg/agent/client/client.go
Outdated
| telemetry.RegistrationID: params[i].EntryId, | ||
| telemetry.Status: r.Status.Code, | ||
| telemetry.Error: r.Status.Message, | ||
| }).Warn("Fails to mint X509 SVID") |
There was a problem hiding this comment.
nit:
Suggested change
| }).Warn("Fails to mint X509 SVID") | |
| }).Warn("Failed to mint X509 SVID") |
This change updates the agent to use the new server APIs unconditionally and removes the experimental flag. It is a little larger than expected, mostly due to updates to unit-tests that had a strong coupling/dependency on the agent client, in particular the manager tests. I was going to go for a larger refactor but that would be mostly wasted effort since we have planned work that will shake everything up in these layers quite a bit when we implement the agent feature to do a "soft" restart when it needs to re-attest. Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
Also cleaned up some of the types conversion functions now used in the tests. Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
azdagron
force-pushed
the
switch-agent-to-new-apis
branch
from
1ed3263
to
4990a73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the agent to use the new server APIs unconditionally and removes the experimental flag.
It is a little larger than expected, mostly due to updates to unit-tests that had a strong coupling/dependency on the agent client, in particular the manager tests. I was going to go for a larger refactor but that would be mostly wasted effort since we have planned work that will shake everything up in these layers quite a bit when we implement the agent feature to do a "soft" restart when it needs to re-attest.