API Refactor: fix rate limiter warning when handler not invoked #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rate limiter is supposed to warn if the handler did not invoke the limiter (suggesting a bug in the handler implementation), except when the handler returns InvalidArgument. The conditional in the rate limiter middleware was incorrect causing the warning to be issued even when the handler was never invoked. This change fixes the rate limiter. It also moves the authorization middleware above the rate limiting middleware as a precaution. Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
mcpherrinm
as code owners
amartinezfayo
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rate limiter is supposed to warn if the handler did not invoke the limiter (suggesting a bug in the handler implementation), except when the handler returns InvalidArgument.
The conditional in the rate limiter middleware was incorrect causing the warning to be issued even when the handler was never invoked.
This change: