Fix fatal error when k8s registrar leader election enabled #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to default in older versions of controller-runtime, but the behaviour changed and now it must be specified. Enable leader election in the integration test for reconcile, since it's a flag that's unlikely to get adhoc testing. Signed-off-by: Jonathan Oddy <jonathan.oddy@transferwise.com>
JonathanO
requested review from
amartinezfayo,
APTy,
azdagron,
evan2645 and
mcpherrinm
as code owners
|
@faisal-memon I've added the parameter for crd mode too. It has no impact if leader election is disabled. It just sets the name of the ConfigMap to use for leader election. The behaviour was changed in controller-runtime because the default used to be "controller", which led to collisions between different controllers if people hadn't altered it to make it unique to their controller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LeaderElectionID used to have a default in older versions of controller-runtime, but now needs setting explicitly. Without it set the registrar will fatal error when reconcile/crd modes have leader election enabled. Populate it with a sensible value, based on the configured controller name for reconcile mode, or a fixed value for crd mode.
Also enable leader election in the integration test for reconcile, since it's a flag that's unlikely to get adhoc testing otherwise.