Fix error message when attestation is disabled #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
mcpherrinm
as code owners
When attestation rate limiting is disabled in the middleware, the AttestAgent RPC is still invoking the rate limiter. This causes the middleware to log that there is a bug, since an RPC was either not limited (and not expected to invoke the limiter) or was limited (and expected to invoke the limiter). This change introduces a new kind of limit, the "disabled" limit and fixes the middleware layer to still expect the rate limiter to be invoked by the RPC for disabled limits. It then changes the rate limiting configuration to use the "disabled" limit for Agent.AttestAgent when attestation rate limiting is disabled. Signed-off-by: Andrew Harding <aharding@vmware.com>
azdagron
force-pushed
the
fix-rate-limit-error-log-on-disabled-attestation
branch
from
ec61286
to
d4c3f29
Compare
tyler-at-fast
approved these changes
Oct 7, 2020
APTy
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Server no longer logs a misleading and incorrect error message on attestation attempts when attestation limits are disabled.
Description of change
When attestation rate limiting is disabled in the middleware, the AttestAgent RPC is still invoking the rate limiter. This causes the
middleware to log that there is a bug, since an RPC was either not limited (and not expected to invoke the limiter) or was limited (and expected to invoke the limiter).
This change introduces a new kind of limit, the "disabled" limit and fixes the middleware layer to still expect the rate limiter to be
invoked by the RPC for disabled limits.
It then changes the rate limiting configuration to use the "disabled" limit for Agent.AttestAgent when attestation rate limiting is disabled.
Which issue this PR fixes
Fixes #1898