Rate limit misconfiguration logging #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
mcpherrinm
as code owners
Rate limits misconfiguration log messages to once a minute. Each RPC/message combination is rate limited individually. Signed-off-by: Andrew Harding <aharding@vmware.com>
azdagron
force-pushed
the
rate-limit-misconfiguration-logs
branch
from
06af43a
to
9f96496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Rate limits misconfiguration log messages to once a minute. Each RPC/message combination is rate limited individually.
Description of change
Timestamps for each misconfiguration RPC/message combo are maintained. If it has been less than a minute since the last time a specific misconfiguration message for an RPC has been logged, then the logging is not performed.
Which issue this PR fixes
#1900