Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke run subcommand from scratch image entrypoint #2582

Conversation

azdagron
Copy link
Member

@azdagron azdagron commented Oct 4, 2021

This makes them differ from the non-scratch images and adds undue friction when switching over.

Signed-off-by: Andrew Harding <aharding@vmware.com>
evan2645
evan2645 previously approved these changes Oct 4, 2021
Copy link
Member

@evan2645 evan2645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @azdagron! Thank you ❤️

Signed-off-by: Andrew Harding <aharding@vmware.com>
@azdagron azdagron merged commit f5607e8 into spiffe:main Oct 4, 2021
@azdagron azdagron deleted the invoke-run-subcommand-from-scratch-image-entrypoint branch October 4, 2021 20:44
@azdagron azdagron added this to the 1.1.0 milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants