Add pagination support for spire-server entry show command
#3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryuma Yoshida <ryumyosh@zlab.co.jp>
ryysud
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
ryysud
commented
Jun 3, 2022
cmd/spire-server/cli/entry/show.go
Outdated
| @@ -15,6 +15,8 @@ import ( | |||
| "golang.org/x/net/context" | |||
| ) | |||
|
|
|||
| const listEntriesRequestPageSize = 1000 | |||
There was a problem hiding this comment.
I do not understand what size should be defined...
There was a problem hiding this comment.
That's a great question :) The benefit of paging the response is that in deployments with significant amounts of entries, we can exceed the gRPC message size limit (4MB). With 1000 entries, that gives us roughly 4K per entry, which seems reasonable except that SPIFFE ID's can technically be up to 2048 bytes each. I don't think we need to be too precise here. What if we just went for 500?
Signed-off-by: Ryuma Yoshida <ryumyosh@zlab.co.jp>
azdagron
approved these changes
Jun 8, 2022
stevend-uber
pushed a commit
to stevend-uber/spire
that referenced
this pull request
Oct 16, 2023
…3135) Signed-off-by: Ryuma Yoshida <ryumyosh@zlab.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryuma Yoshida ryumyosh@zlab.co.jp
Pull Request check list
Affected functionality
spire-server entry showcommand.Description of change
Pagination support for
spire-server entry showcommand.Which issue this PR fixes
Fixes #2443.