Add configuration on Agent to set X509SVID key type #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
MarcosDY
requested review from
evan2645,
amartinezfayo,
azdagron and
rturner3
as code owners
azdagron
reviewed
Jul 19, 2022
cmd/spire-agent/cli/run/run_test.go
Outdated
| msg: "workload_key_type invalid value", | ||
| expectError: true, | ||
| input: func(c *Config) { | ||
| c.Agent.WorkloadKeyType = "no a key" |
pkg/agent/workloadkey/workloadkey.go
Outdated
| return nil, fmt.Errorf("unknown key type %q", keyType) | ||
| } | ||
|
|
||
| func (keyType KeyType) SignatureAlgorithm() (x509.SignatureAlgorithm, error) { |
There was a problem hiding this comment.
I wonder if we shouldn't just rely on the Go standard library choice for the signature algorithm....
There was a problem hiding this comment.
done, I removed SignatureAlgorithm and rely on Go standard library
cmd/spire-agent/cli/run/run.go
Outdated
| @@ -69,6 +70,7 @@ type agentConfig struct { | |||
| ServerAddress string `hcl:"server_address"` | |||
| ServerPort int `hcl:"server_port"` | |||
| SocketPath string `hcl:"socket_path"` | |||
| WorkloadKeyType string `hcl:"workload_key_type"` | |||
There was a problem hiding this comment.
Hmm. Wonder if we shouldn't be more specific that this is for the X509-SVID.... workload_x509_svid_key_type? What do you think?
There was a problem hiding this comment.
I like workload_x509_svid_key_type I was thinking on something like that, to avoid confusion
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
stevend-uber
pushed a commit
to stevend-uber/spire
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration on Agent to set X509SVID key type
Which issue this PR fixes
fixes #3226