-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add denied details to errors on server authorization #3269
Conversation
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MarcosDY ! I just have one small comment. Thanks for the targeted fix and unit tests!
return ctx, false, err | ||
} | ||
return ctx, false, nil | ||
return ctx, false, err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can refactor isAgent
to no longer return a bool...
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
…turn a boolean Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @MarcosDY !
Add authentication error reason to opa error message Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Add denied details to PermissionDenied errors generated from Authorization process.
It allows agent to reattest when agent entry is removed
Which issue this PR fixes
fixes #3268