Update aws node attestor plugin to include new selectors #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tance identity document Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
guilhermocc
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
guilhermocc
changed the title
rturner3
reviewed
Dec 9, 2022
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
rturner3
approved these changes
Dec 9, 2022
divaspathak
pushed a commit
to divaspathak/spire
that referenced
this pull request
Dec 24, 2022
* Update aws node attestor plugin to include new selectors from the instance identity document Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com> Signed-off-by: divaspathak <divaspathak@gmail.com>
stevend-uber
pushed a commit
to stevend-uber/spire
that referenced
this pull request
Oct 16, 2023
* Update aws node attestor plugin to include new selectors from the instance identity document Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list ✔️
Affected functionality 🤔
Selectors generated on AWS iid node attestor plugin.
Description of change ✍️
Include new selectors that are generated on AWS iid node attestor plugin, these new values are retrieved from the instance identity document used for node attestation:
aws_iid:az:us-west-2baws_iid:image:id:ami-5fb8c835aws_iid:instance:id:i-0b22a22eec53b9321aws_iid:region:us-west-2Which issue this PR fixes ❓
fixes #3514