Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain node info on SDS stream when omitted from subsequent requests #4611

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Retain node info on SDS stream when omitted from subsequent requests #4611

merged 4 commits into from
Oct 26, 2023

Conversation

grameshtwilio
Copy link
Contributor

@grameshtwilio grameshtwilio mentioned this pull request Oct 26, 2023
Closed
azdagron
azdagron reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just one small suggestion.

pkg/agent/endpoints/sdsv3/handler.go Outdated Show resolved Hide resolved
dependabot bot and others added 3 commits October 26, 2023 09:05
@dependabot @grameshtwilio
Bump the aws-sdk group with 2 updates (spiffe#4610)
a12ffdf 
Bumps the aws-sdk group with 2 updates: [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) and [github.com/aws/aws-sdk-go-v2/service/iam](https://github.com/aws/aws-sdk-go-v2).

Updates `github.com/aws/aws-sdk-go-v2/service/ec2` from 1.126.0 to 1.127.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/ec2/v1.126.0...service/ec2/v1.127.0)

Updates `github.com/aws/aws-sdk-go-v2/service/iam` from 1.22.0 to 1.24.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.24.0/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.22.0...service/s3/v1.24.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
- dependency-name: github.com/aws/aws-sdk-go-v2/service/iam
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio
patching sds handler to remember node info
12d9a73 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio @azdagron
Update pkg/agent/endpoints/sdsv3/handler.go
2a93f64 
Co-authored-by: Andrew Harding <azdagron@gmail.com>
Signed-off-by: grameshtwilio <gramesh@twilio.com>
azdagron
azdagron previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @grameshtwilio!

@azdagron azdagron added this to the 1.8.4 milestone Oct 26, 2023
@azdagron azdagron changed the title patching sds handler to remember node info Retain node info on SDS stream when subsequent requests omit it Oct 26, 2023
@azdagron azdagron changed the title Retain node info on SDS stream when subsequent requests omit it Retain node info on SDS stream when omitted from subsequent requests Oct 26, 2023
@azdagron azdagron merged commit 00f2825 into spiffe:main Oct 26, 2023
31 checks passed
@amartinezfayo amartinezfayo modified the milestones: 1.8.4, 1.8.5 Nov 8, 2023
faisal-memon pushed a commit to faisal-memon/spire that referenced this pull request Dec 2, 2023
@grameshtwilio @dependabot
@azdagron @faisal-memon
Retain node info on SDS stream when omitted from subsequent requests (s…
6eba012 
…piffe#4611)

* Bump the aws-sdk group with 2 updates (spiffe#4610)

Bumps the aws-sdk group with 2 updates: [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) and [github.com/aws/aws-sdk-go-v2/service/iam](https://github.com/aws/aws-sdk-go-v2).

Updates `github.com/aws/aws-sdk-go-v2/service/ec2` from 1.126.0 to 1.127.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/ec2/v1.126.0...service/ec2/v1.127.0)

Updates `github.com/aws/aws-sdk-go-v2/service/iam` from 1.22.0 to 1.24.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.24.0/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.22.0...service/s3/v1.24.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
- dependency-name: github.com/aws/aws-sdk-go-v2/service/iam
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: grameshtwilio <gramesh@twilio.com>

* patching sds handler to remember node info

Signed-off-by: grameshtwilio <gramesh@twilio.com>

* Update pkg/agent/endpoints/sdsv3/handler.go

Co-authored-by: Andrew Harding <azdagron@gmail.com>
Signed-off-by: grameshtwilio <gramesh@twilio.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: grameshtwilio <gramesh@twilio.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Harding <azdagron@gmail.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azdagron azdagron azdagron approved these changes

@evan2645 evan2645 Awaiting requested review from evan2645 evan2645 is a code owner

@amartinezfayo amartinezfayo Awaiting requested review from amartinezfayo amartinezfayo is a code owner

@MarcosDY MarcosDY Awaiting requested review from MarcosDY MarcosDY is a code owner

@rturner3 rturner3 Awaiting requested review from rturner3 rturner3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grameshtwilio @azdagron @amartinezfayo