Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document BundlePublisher #4951

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Conversation

c4rlo
Copy link
Contributor

@c4rlo c4rlo commented Mar 6, 2024

Mention the BundlePublisher plugin type, and its built-in aws_s3 implementation, on the SPIRE Server Configuration Reference page.

This plugin type was introduced in spiffe/spire-plugin-sdk#38. See also #2909, #4034.

While I'm touching this, a couple of other tweaks:

  • Add CredentialComposer to plugin type list (its uniqueid implementation was already mentioned in the built-in plugin table).
  • Reorder the tables of plugin types and built-in plugins to hopefully make a little more sense, and to be consistent with each other.
  • Change a "sql" to a "SQL".

Mention the BundlePublisher plugin type, and its built-in aws_s3
implementation, on the SPIRE Server Configuration Reference page.

This plugin type was introduced in spiffe/spire-plugin-sdk#38.
See also spiffe#2909, spiffe#4034.

While I'm touching this, a couple of other tweaks:

- Add CredentialComposer to plugin type list (its uniqueid
  implementation was already mentioned in the built-in plugin table).
- Reorder the tables of plugin types and built-in plugins to hopefully
  make a little more sense, and to be consistent with each other.
- Change a "sql" to a "SQL".

Signed-off-by: Carlo Teubner <cteubner1@bloomberg.net>
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @c4rlo!

@amartinezfayo amartinezfayo merged commit 91ddf4f into spiffe:main Mar 8, 2024
32 checks passed
@amartinezfayo amartinezfayo added this to the 1.9.2 milestone Mar 8, 2024
rushi47 pushed a commit to rushi47/spire that referenced this pull request Apr 11, 2024
Mention the BundlePublisher plugin type, and its built-in aws_s3
implementation, on the SPIRE Server Configuration Reference page.

This plugin type was introduced in spiffe/spire-plugin-sdk#38.
See also spiffe#2909, spiffe#4034.

While I'm touching this, a couple of other tweaks:

- Add CredentialComposer to plugin type list (its uniqueid
  implementation was already mentioned in the built-in plugin table).
- Reorder the tables of plugin types and built-in plugins to hopefully
  make a little more sense, and to be consistent with each other.
- Change a "sql" to a "SQL".

Signed-off-by: Carlo Teubner <cteubner1@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants