Do not rotate JWT keys if X509 preparation failed during initialization #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
requested review from
evan2645,
azdagron,
MarcosDY and
rturner3
as code owners
amartinezfayo
changed the title
rturner3
reviewed
Apr 15, 2024
pkg/server/ca/manager/journal.go
Outdated
| @@ -231,6 +231,10 @@ func (j *Journal) saveInDatastore(ctx context.Context, entriesBytes []byte) (caJ | |||
| // Check if we already identified what's the CA journal for this server in | |||
| // the datastore. If not, log that we are creating a new CA journal entry. | |||
| if j.caJournalID == 0 { | |||
| if j.activeX509AuthorityID == "" { | |||
| j.config.log.Debug("There is no active X509 authority yet. Can't save CA journal in the datastore") | |||
There was a problem hiding this comment.
Suggested change
| j.config.log.Debug("There is no active X509 authority yet. Can't save CA journal in the datastore") | |
| j.config.log.Debug("There is no active X.509 authority yet. Can't save CA journal in the datastore") |
nit
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
rturner3
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not try to rotate JWT keys if X509 preparation failed during initialization (there is no current X509 authority slot).
In this condition, even if the JWT keys can be rotated, the rotate operation will return an unrecoverable error that will make the server to shut down.
Additionally, make sure to add a new CA journal record when we have an active X509 authority ID.
Fixes #5038.