Updates node API to support JWT SVID #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
amartinezfayo,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
- Adds JWT methods to node API and renames things to clearly distinguish between JWT and X509 - Updates agent client to support fetching JWT SVIDs - Provides server stub Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
force-pushed
the
node-api-jwt-svid-support
branch
from
bd2f697
to
5005aaf
Compare
evan2645
approved these changes
Jul 23, 2018
| string spiffe_id = 1; | ||
|
|
||
| // List of intended audience | ||
| repeated string audience = 2; |
There was a problem hiding this comment.
Side note: any thoughts on where token lifetime might get configured?
There was a problem hiding this comment.
expiration isn't part of x509-SVID CSR's and the expiration is configured in one of two ways:
- Agent SVID's get the default TTL
- Workload SVID's get a TTL based on the registration entry.
I intended JWT-SVID's to follow suit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
between JWT and X509
Fixes #495