Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSG] - Spike Train Sampling rates #12

Closed
TomDonoghue opened this issue Sep 29, 2021 · 1 comment
Closed

[DSG] - Spike Train Sampling rates #12

TomDonoghue opened this issue Sep 29, 2021 · 1 comment
Assignees
Labels
0.1 Update to go into the 0.1.0 release. question Further information is requested

Comments

@TomDonoghue
Copy link
Member

TomDonoghue commented Sep 29, 2021

Spike trains have a sampling rate, but right now when we use them, this is little impicit (defaults to 1kHz, but doesn't document this, and has no options for changing.) This should be documented, and made more generalizable

Functions to check for this:

  • convert_train_to_times
  • create_spike_train
  • maybe others (to check)

Also: computing spike trains depends on the unit of the data (ms vs. second), and the start time of the task. For examples, it blows up if times are encoded in UNIX time (as it tries to create a spike_train from time 0).

Note: relates to #5

@TomDonoghue TomDonoghue changed the title Spike Train Sampling rates [DSG] - Spike Train Sampling rates Sep 29, 2021
@TomDonoghue TomDonoghue added 0.1 Update to go into the 0.1.0 release. question Further information is requested labels Oct 11, 2021
@TomDonoghue TomDonoghue self-assigned this Oct 14, 2021
@TomDonoghue TomDonoghue mentioned this issue Nov 12, 2021
13 tasks
@TomDonoghue
Copy link
Member Author

This is now done in the linked PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.1 Update to go into the 0.1.0 release. question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant