Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] - Add unit tests #34

Closed
9 tasks done
TomDonoghue opened this issue Oct 12, 2021 · 2 comments
Closed
9 tasks done

[MNT] - Add unit tests #34

TomDonoghue opened this issue Oct 12, 2021 · 2 comments
Assignees
Labels
0.1 Update to go into the 0.1.0 release. Maintenance

Comments

@TomDonoghue
Copy link
Member

TomDonoghue commented Oct 12, 2021

Functions that need unit-tests adding:

@TomDonoghue
Copy link
Member Author

Hey @claire98han & @maestapereira - thanks for all the work on this, we are super close!

As well as the open PR (#68), I updated the comment above to untick the sim_spiketrain_prob and sim_spiketrain_binom functions - the listed PR was for the warning that got added, but unless I'm missing the tests are still ToDo. Once those are added, we are finished this task!

@maestapereira
Copy link
Collaborator

Hi @TomDonoghue, you're right - thanks for correcting it!
I wrote the functions but didn't add them to a branch and didn't open PRs. I will do that right away:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.1 Update to go into the 0.1.0 release. Maintenance
Projects
None yet
Development

No branches or pull requests

3 participants