Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track algorithm/model used to correct a label #75

Open
valosekj opened this issue Jan 25, 2024 · 1 comment
Open

Track algorithm/model used to correct a label #75

valosekj opened this issue Jan 25, 2024 · 1 comment

Comments

@valosekj
Copy link
Member

The manual_correction.py currently generates the following JSON sidecars using code here:

{
    "GeneratedBy": [
        {
            "Author": "Jan Valosek",
            "Date": "2024-01-18 10:42:24"
        }
    ]
}

But, in many cases, we do not create labels completely from scratch. Instead, we correct labels obtained using some method (sct_deepseg_sc, custom models, etc.). Thus, it would be a good idea to store the info about the method in the JSON sidacars, for example:

{
    "GeneratedBy": [
        {
            "Name": "SCISeg nnUNet3D",
            "Version": "Dataset183_tSCI3SitesALPhase2Seed710",
            "Date": "2024-01-16"
        },
        {
            "Author": "Jan Valosek",
            "Note": "Manually corrected",
            "Date": "2024-01-18 10:42:24"
        }
    ]
}

In the future, SCT functions will generate JSON sidecars tracking such info, see this PR: spinalcordtoolbox/spinalcordtoolbox#3394. Until then, and also for future models in development before integration to SCT, we could add an input arg to the manual_correction.py, allowing us to provide specific information to include in JSON sidecars.

Relevant comments: #34, ivadomed/canproco#73

Our intranet convention: https://intranet.neuro.polymtl.ca/data/dataset-curation.html#json-sidecars

@valosekj
Copy link
Member Author

Custom metadata can now be provided using -json-metadata flag; see #80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant