Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation error not caught by Travis #1679

Closed
jcohenadad opened this issue Apr 12, 2018 · 2 comments
Closed

Installation error not caught by Travis #1679

jcohenadad opened this issue Apr 12, 2018 · 2 comments
Assignees
@zougloub

Comments

@jcohenadad
Copy link
Member

https://travis-ci.org/neuropoly/spinalcordtoolbox/jobs/364742340#L1422

need to check if the recent updates on install_sct fix it
@jcohenadad
Copy link
Member Author

nope! recent updates did not fix it:
https://travis-ci.org/neuropoly/spinalcordtoolbox/jobs/365429679#L1499

@zougloub
Copy link
Contributor

Issues identified:

  • sct_check_dependencies failing which nevertheless causes "Installation successful"
  • an msct_parser warning
  • Check if pytest-cov (2.5.1) is installed............[FAIL] (on your second link)

zougloub added a commit that referenced this issue Apr 12, 2018
@zougloub
install_sct: don't pretend installation is successful if sct_check_de…
4dd7c1d 
…pendencies failed (#1679)
zougloub added a commit that referenced this issue Apr 12, 2018
@zougloub
sct_check_dependencies: override pytest-cov module name (#1679)
7a12b21
@zougloub zougloub mentioned this issue Apr 12, 2018
Merged
zougloub added a commit that referenced this issue Apr 17, 2018
@zougloub
install_sct: don't pretend installation is successful if sct_check_de…
2529304 
…pendencies failed (#1679)
zougloub added a commit that referenced this issue Apr 17, 2018
@zougloub
sct_check_dependencies: override pytest-cov module name (#1679)
c80e16f
jcohenadad pushed a commit that referenced this issue Apr 25, 2018
@zougloub @jcohenadad
Fixup benign installation failures from #1679 (#1680)
b20224d 
* msct_parser: fixup redundant log.info parameter causing warnings

* install_sct: don't pretend installation is successful if sct_check_dependencies failed (#1679)

* sct_check_dependencies: override pytest-cov module name (#1679)

* sct_make_ground_truth: fixup typo
jcohenadad added a commit that referenced this issue May 9, 2018
@jcohenadad
Merge branch 'master' into jca_readme
ade7d5b 
* master: (31 commits)
  Control the brightness of the image in the GUI. (#1684)
  Refactor things dealing with dataset `info_label.txt` metadata file (#1676)
  Implements MTsat function (#1672)
  Keep intermediate temp folder by default (#1694)
  sct_deepseg_sc - Issue when input is .nii instead of .nii.gz (#1634, #1659)
  sct_image: remove file removal kludge (#1688) (#1705)
  Concatenate string to keep previously assigned subtitle field (fixes #1690) (#1692)
  Enable input file with label at a specific disc (#1698)
  Use python  concurrent.futures instead of multiprocessing  (#1587)
  Fixup benign installation failures from #1679 (#1680)
  output of -display ordered per label value (#1686)
  Slice counting fixed (#1687)
  Travis: binaries: install libvtk6 or libvtk7
  Travis: isct_propseg: install more deps
  Travis: attempt to build propseg
  isct_propseg: link with ITKIOTransformBase
  isct_propseg: some C++ clean-up
  Rearranged the imports and removed the cyclic imports. (#1511)
  msct_register_landmarks: fixup default path_qc
  sct_warp_template: WarpTemplate: remove dead ctor argument
  ...
jcohenadad pushed a commit that referenced this issue Dec 18, 2019
@zougloub @jcohenadad
Fixup benign installation failures from #1679 (#1680)
96012f2 
* msct_parser: fixup redundant log.info parameter causing warnings

* install_sct: don't pretend installation is successful if sct_check_dependencies failed (#1679)

* sct_check_dependencies: override pytest-cov module name (#1679)

* sct_make_ground_truth: fixup typo


Former-commit-id: b20224d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zougloub zougloub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zougloub @jcohenadad