You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
while working on #4477 I noticed that the output syntax of sct_apply_transfo is missing the output file name:
julien-macbook:~/temp/Lydia/results_20240430_225215/data_processed/sub-BB277/anat $ sct_apply_transfo -i sub-BB277_T2_straight.nii.gz -d sub-BB277_T2.nii.gz -w warp_straight2curve.nii.gz --Spinal Cord Toolbox (git-master-4e3b9ebbbd6672169a8bdfd9c5fde4b81716eaa7)sct_apply_transfo -i sub-BB277_T2_straight.nii.gz -d sub-BB277_T2.nii.gz -w warp_straight2curve.nii.gz--Parse list of warping fields...Get dimensions of data... 63 x 89 x 318 x 1Apply transformation...Apply transformation and resample to destination space.../Users/julien/code/spinalcordtoolbox/bin/isct_antsApplyTransforms -d 3 -i sub-BB277_T2_straight.nii.gz -o sub-BB277_T2_straight_reg.nii.gz -t warp_straight2curve.nii.gz -r sub-BB277_T2.nii.gz -n 'BSpline[3]' # in /Users/julien/temp/Lydia/results_20240430_225215/data_processed/sub-BB277/anatCopy affine matrix from destination space to make sure qform/sform are the same.Done! To view results, type:fsleyes sub-BB277_T2.nii.gz . &
Notice the last line. I would expect to see this instead:
… `-o` is not passed (#4480)
The fallback filename (`{fname_in}_reg`) was only set inside the context
of the `Transform` class. Meaning, if `-o` wasn't passed, then the
`fsleyes` command would display a blank filename. So, I moved setting
`fname_out` to before we call `Transform`, which is more in line with
our API/CLI separation conventions anyway.
(Side note: I notice that our variable naming conventions are all over
the place for this module (`fname`, `file`, `filename`, etc.). Maybe
that's worth tidying up in this PR, too?)
Fixes#4478.
while working on #4477 I noticed that the output syntax of
sct_apply_transfo
is missing the output file name:Notice the last line. I would expect to see this instead:
The text was updated successfully, but these errors were encountered: