Changed the algorithm to fetch the download filename #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the regex with the parse_header function. Also removed the old download function.
SaraDupont
reviewed
Feb 1, 2017
SaraDupont
reviewed
Feb 1, 2017
scripts/sct_download_data.py
Outdated
|
|
||
| printv('Copy binaries to %s\n' % dest_folder, verbose) |
There was a problem hiding this comment.
Some of the data downloadable by sct_download_data are not binaries (for ex PAM50 and MNI-Poly-AMU are templates, sct_example_data and sct_testing_data are example/testing datasets, etc)
Maybe just print Copy files to xx or Copy data to xx
|
@peristeri: in case of internet glitch the previous function could handle that-- is it still the case with your modification? |
SaraDupont
approved these changes
Feb 1, 2017
jcohenadad
reviewed
Feb 1, 2017
|
@jcohenadad if you are refering to retries on failed attempts? |
Added additional redundancy by retrying download if there's a server or connection error.
|
yes, retry if connection pb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the regex with the parse_header function. Also removed the old
download function.
Fixes #1144