Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make QC generation opt-in #1653

Merged
merged 3 commits into from Apr 10, 2018
Merged

Make QC generation opt-in #1653

merged 3 commits into from Apr 10, 2018

Conversation

zougloub
Copy link
Contributor

@zougloub zougloub commented Mar 22, 2018 •
edited

Automatically writing content in a user's home directory when he didn't state anything is generally not a good idea, and the -qc xxx vs. -noqc is also not the most elegant thing.

This PR simply removes -noqc and makes -qc have a default behavior that doesn't generate QC.

@zougloub zougloub mentioned this pull request Mar 26, 2018
Merged
@zougloub zougloub force-pushed the cJ-no-noqc branch 4 times, most recently from 57e1502 to 6e842a6 Compare April 6, 2018 00:17
@zougloub
get rid of -noqc option, making no qc the default
1a3412a 
This is the only sane thing to do.
@zougloub zougloub requested a review from jcohenadad April 6, 2018 23:46
@jcohenadad
Copy link
Member

jcohenadad commented Apr 9, 2018 •
edited

tested with b46a94e:

  • sct_deepseg_gm
  • sct_deepseg_sc
  • sct_label_vertebrae
  • sct_propseg
  • sct_register_to_template
  • sct_segment_graymatter

jcohenadad
jcohenadad approved these changes Apr 9, 2018
View reviewed changes
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zougloub zougloub merged commit fb568cc into master Apr 10, 2018
@zougloub zougloub deleted the cJ-no-noqc branch April 10, 2018 20:49
@zougloub zougloub mentioned this pull request Apr 16, 2018
Closed
@jcohenadad jcohenadad added this to the 3.2.0 milestone May 29, 2018
@jcohenadad jcohenadad added the enhancement category: improves performance/results of an existing feature label May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcohenadad jcohenadad jcohenadad approved these changes

Assignees
No one assigned
Labels
enhancement category: improves performance/results of an existing feature
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zougloub @jcohenadad