Use pip install -e spinalcordtoolbox to gain flexibility #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zougloub
changed the title
zougloub
changed the title
zougloub
requested review from
random1717 and
jcohenadad
and removed request for
jcohenadad and
random1717
…1702) ... and fixup update_bin.sh to be less quirky
zougloub
requested review from
jcohenadad,
random1717 and
perone
and removed request for
jcohenadad and
random1717
|
Ran tests on this, the installation worked, check_dependencies seem to be fine. |
random1717
approved these changes
Jun 29, 2018
jcohenadad
reviewed
Jun 30, 2018
install_sct
Outdated
| @@ -528,7 +520,7 @@ if [ ${SCT_DEV_MODE} ]; then | |||
| pip install -e ${SCT_SOURCE} | |||
| e_status=$? | |||
| else | |||
| pip install ${SCT_SOURCE} | |||
| pip install -e ${SCT_DIR} | |||
There was a problem hiding this comment.
do we still need to distinguish dev vs. non-dev mode? i.e., maybe we don't need the -z flag anymore?
There was a problem hiding this comment.
If nobody uses it, it could be removed. The only justification for its existence, now, is that with it, we can perform out-of-place installs and edit files that are not in the installation folder (but I have never done that).
jcohenadad
changed the title
jcohenadad
pushed a commit
that referenced
this pull request
Dec 18, 2019
install: use pip install -e spinalcordtoolbox to gain flexibility Former-commit-id: dd5b094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a "solution" for #1702, whereby users can tinker with the running code in all cases:
pip install --upgradeneeded to be ran).Bonus: