Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace parser.usage.generate with parser.error #2621

Merged
merged 2 commits into from Mar 11, 2020
Merged

Replace parser.usage.generate with parser.error #2621

merged 2 commits into from Mar 11, 2020

Conversation

cfhammill
Copy link
Contributor

@cfhammill cfhammill commented Feb 29, 2020 •
edited by jcohenadad

Fixes #2620

@jcohenadad jcohenadad self-requested a review March 10, 2020 20:54
@jcohenadad jcohenadad added the bug category: fixes an error in the code label Mar 10, 2020
@jcohenadad jcohenadad added this to the 4.2.3 milestone Mar 10, 2020
@jcohenadad jcohenadad changed the title [FIX] Replace parser.usage.generate with parser.error Replace parser.usage.generate with parser.error Mar 10, 2020
jcohenadad
jcohenadad approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested! Thanks @cfhammill 👍

@jcohenadad jcohenadad merged commit 91e1378 into master Mar 11, 2020
@jcohenadad jcohenadad deleted the 2020-02-29_parser-errors branch March 11, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcohenadad jcohenadad jcohenadad approved these changes

Assignees
No one assigned
Labels
bug category: fixes an error in the code
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Parser error generation broken in sct_image
2 participants
@cfhammill @jcohenadad