Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow_dispatch for test suite workflows #3399

Merged
merged 1 commit into from May 21, 2021

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented May 20, 2021

Checklist

GitHub

PR contents

Description

This is a small quality of life update for developers. The change allows the test suite to be run manually, targeting a specific branch (this is already in place here, for example). It's useful if you want to quietly test something that you wouldn't be able to test locally (e.g. something specific to the CI) but aren't ready to announce it to everyone with a PR.

One other benefit is being able to manually run the entire test suite once for a PR's branch without having to awkwardly comment out the if: conditional.

Linked issues

N/A

This allows them to be run manually targeting specific branches,
as a quality of life update for developers. (No PRs required for
testing!)
@joshuacwnewton joshuacwnewton added the CI category: TravisCI, GitHub Actions, etc. label May 20, 2021
@joshuacwnewton joshuacwnewton added this to the 5.3.1 milestone May 20, 2021
@joshuacwnewton joshuacwnewton requested a review from a team May 20, 2021 21:10
Copy link
Collaborator

@Drulex Drulex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@joshuacwnewton joshuacwnewton merged commit 77d4b7d into master May 21, 2021
@joshuacwnewton joshuacwnewton deleted the jn/add-workflow-dispatch-to-ci branch May 21, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI category: TravisCI, GitHub Actions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants